FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Set HOMEBREW_NO_INSTALL_CLEANUP to speedup brew installs by Avasam · Pull Request #9713 · python/typeshed · GitHub

Set HOMEBREW_NO_INSTALL_CLEANUP to speedup brew installs - #9713

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
Avasam:HOMEBREW_NO_INSTALL_CLEANUP
Feb 11, 2023
Merged

Set HOMEBREW_NO_INSTALL_CLEANUP to speedup brew installs#9713
JelleZijlstra merged 1 commit into
python:mainfrom
Avasam:HOMEBREW_NO_INSTALL_CLEANUP

Conversation

Avasam commented Feb 11, 2023
edited
Loading

Copy link
Copy Markdown
Collaborator

As the inline comment says: Speedup brew install. Environments are isolated, no need to cleanup old versions.
While working on a PR that touched pyaudio, I noticed this from runs like https://github.com/python/typeshed/actions/runs/4148676771/jobs/7176901691#step:5:54

I also moved the NONINTERACTIVE under env

JelleZijlstra merged commit 2930f8c into python:main Feb 11, 2023

Copy link
Copy Markdown
Member

Thanks!

Avasam deleted the HOMEBREW_NO_INSTALL_CLEANUP branch February 11, 2023 19:21

AlexWaygood commented Feb 20, 2023
edited
Loading

Copy link
Copy Markdown
Member

I don't know much about homebrew -- would it be worth adding the other two environment variables that were just added to CPython's workflow in https://github.com/python/cpython/pull/102074/files as well?

Avasam commented Feb 20, 2023
edited
Loading

Copy link
Copy Markdown
Collaborator Author

I don't know much about homebrew -- would it be worth adding the other two environment variables that were just added to CPython's workflow in python/cpython#102074 (files) as well?

Me neither, but here's the doc: https://docs.brew.sh/Manpage#environment
HOMEBREW_NO_AUTO_UPDATE definitely. For the same reasons we don't need to update pip in the CI
HOMEBREW_NO_ANALYTICS is up to you I guess. Analytics is good for the homebrew devs. I think it's more a matter of opting out of data collection than speeding up CI (although anything that speeds up CI isn't bad either): https://docs.brew.sh/Analytics#opting-out

Copy link
Copy Markdown
Member

HOMEBREW_NO_ANALYTICS is up to you I guess. Analytics is good for the homebrew devs. I think it's more a matter of opting out of data collection than speeding up CI (although anything that speeds up CI isn't bad either): https://docs.brew.sh/Analytics#opting-out

Running stubtest on macOS in CI is consistently slowesr/more backed-up than the other two operating systems, so I'd be up for it tbh :p

Copy link
Copy Markdown
Member

Also, same as CPython (python/cpython#102074 (comment)), we're probably somewhat atypical users of homebrew 😄

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL