Delete "Passing kwargs inside a function to another function section" - #1960
Closed
yangdanny97 wants to merge 3 commits into
Closed
Delete "Passing kwargs inside a function to another function section"#1960yangdanny97 wants to merge 3 commits into
yangdanny97 wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
yangdanny97
marked this pull request as ready for review
April 13, 2025 05:04
Copy link
Copy Markdown
Member
|
Sorry we let this sit. We've since made some similar conformance suite changes in #2272 and #2301, and we've accepted PEP 728. In that light, it might be time to revise the spec to work consistent with PEP 728's new mechanisms: closed TypedDicts can't have extra keys; open ones can. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I'll close this one and make a new PR when I have time |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context is in example 2 from #1918
It doesn't make sense to enforce this requirement for just **kwargs but not any other arguments annotated with a TypedDict, and additionally, no typecheckers currently implement this.
It seems like https://discuss.python.org/t/typing-spec-inconsistency-for-unpacking-typed-dict-kwargs/79640 didn't get any responses. I'll bump the discussion again but for now I'll make a PR here so I don't forget about it.