FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

clarify `Final` reassignment semantics by KotlinIsland · Pull Request #2241 · python/typing · GitHub

/ typing Public

clarify Final reassignment semantics - #2241

Open
KotlinIsland wants to merge 1 commit into
python:mainfrom
KotlinIsland:final-reassignment
ConversationCommits (1)ChecksFiles changed
Open

clarify Final reassignment semantics#2241
KotlinIsland wants to merge 1 commit into
python:mainfrom
KotlinIsland:final-reassignment

Conversation

KotlinIsland commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

carljm requested changes Apr 7, 2026
View reviewed changes

carljm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this is a superior rule, but I would be likely to think so, since it's the rule ty already implements 😆

I think this PR needs some improvements, but I'm in favor of the change.

Comment thread conformance/tests/qualifiers_final_annotation.py Outdated
Comment thread conformance/results/pyright/qualifiers_final_annotation.toml
Comment thread conformance/results/ty/qualifiers_final_annotation.toml Outdated
Comment thread conformance/results/zuban/qualifiers_final_annotation.toml Outdated
Comment thread docs/spec/qualifiers.rst Outdated
KotlinIsland force-pushed the final-reassignment branch 2 times, most recently from db50e16 to 790786b Compare April 7, 2026 11:53
KotlinIsland requested a review from carljm April 7, 2026 11:53
carljm reviewed Apr 8, 2026
View reviewed changes
Comment thread conformance/tests/qualifiers_final_annotation.py
else:
ID3 = 2 # OK

ID4: Final[int] # E: not exhaustive assignment

carljm Apr 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure I agree that it should be required to enforce exhaustive assignment. Why should this be enforced for a Final name, but not for other names?

KotlinIsland Apr 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

i would expect a type checker to enforce this for all names. but this change is only regarding Final, which to me is even more "static" than normal variables, that a Final name without a value should always be impossible

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

carljm carljm requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL