FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

conformance: bump type checker versions by rchen152 · Pull Request #2254 · python/typing · GitHub

/ typing Public

conformance: bump type checker versions - #2254

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
rchen152:bump
Apr 8, 2026
Merged

conformance: bump type checker versions#2254
JelleZijlstra merged 1 commit into
python:mainfrom
rchen152:bump

Conversation

rchen152 commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

mypy: 1.19.1 -> 1.20.0
pyrefly: 0.58.0 -> 0.60.0
zuban: 0.6.2 -> 0.7.0

mypy: 1.19.1 -> 1.20.0
pyrefly: 0.58.0 -> 0.60.0
zuban: 0.6.2 -> 0.7.0
JelleZijlstra merged commit c289935 into python:main Apr 8, 2026
5 checks passed
Comment on lines +6 to +7
dataclasses_descriptors.py:61: error: Cannot access instance-only attribute "x" on class object [misc]
dataclasses_descriptors.py:62: error: Cannot access instance-only attribute "y" on class object [misc]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

these new mypy diagnostics seem like they might be worth describing in the notes field? Especially because pyrefly and ty also object to the assertions on these lines, for basically the same reason: descriptors resolve differently when accessed on the class object than when accessed on instances, and the assertions on these lines don't seem fully cognisant of that aspect of the runtime behaviour

"""
conformance_automated = "Fail"
errors_diff = """
Lines 111, 112: Expected error (tag 'func6_3')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should this also be mentioned in the notes field?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For neither assert_type to error, I think mypy must be marking this match case as unreachable. Amusingly enough, this is the third time this has happened - I previously filed bugs against zuban and pyright for this.

rchen152 deleted the bump branch April 8, 2026 21:20
rchen152 added a commit to rchen152/typing that referenced this pull request Apr 8, 2026
Addressing a couple comments on python#2254 that came in after the PR was merged.
rchen152 added a commit that referenced this pull request Apr 8, 2026
Addressing a couple comments on #2254 that came in after the PR was merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL