Remove questionable dataclass descriptor conformance assertions - #2296
Closed
BHUVANSH855 wants to merge 3 commits into
Closed
Remove questionable dataclass descriptor conformance assertions#2296BHUVANSH855 wants to merge 3 commits into
BHUVANSH855 wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
BHUVANSH855
force-pushed
the
fix-2259-dataclass-descriptor-tests
branch
from
aee0e78 to
15e4fe0
Compare
May 28, 2026 17:26
BHUVANSH855
force-pushed
the
fix-2259-dataclass-descriptor-tests
branch
from
15e4fe0 to
c48ab35
Compare
May 28, 2026 17:29
BHUVANSH855
force-pushed
the
fix-2259-dataclass-descriptor-tests
branch
from
09c8961 to
d6caba9
Compare
May 28, 2026 17:40
Copy link
Copy Markdown
Collaborator
|
Closing, because there is also #2299, which seems more promising and tries to fix the exact same issue. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove questionable Desc2 conformance assertions from dataclasses_descriptors.py.
The existing assertions do not align with actual runtime behavior for non-data descriptors in dataclasses:
Since this behavior is currently under-specified and differs across type checkers and runtime semantics, this PR removes the questionable assertions and replaces them with explanatory comments.
Fixes #2259