Repository navigation
Add a (somewhat simple-minded) cache to the Python 2 version too. - #291
Merged
gvanrossum merged 2 commits intoOct 5, 2016
Merged
gvanrossum merged 2 commits into
gvanrossum merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@ilevkivskyi Do you see anything wrong with this? |
Sorry, something went wrong.
ilevkivskyi
reviewed
Oct 5, 2016
Comment thread
python2/typing.py
Outdated
| AnyStr = TypeVar('AnyStr', bytes, unicode) | ||
|
|
||
|
|
||
| def _tp_cache(func, maxsize=128): |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
A small comment: With this definition we could not later write:
@_tp_cache(maxsize=200)
def __getitem__(self, parameters):
...This causes an error (function takes at least 1 argument...). I would propose to either make maxsize a constant MAXSIZE or use the decorator with args pattern here.
Except for this small comment, everything LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It's not tunable in the Python 3 version either, so I just made it a local. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290. Timing example:
Without cache:
With cache:
That's about a 300x speedup!