Repository navigation
Add AsyncContextManager generic class - #438
Merged
gvanrossum merged 7 commits intoJun 9, 2017
Merged
gvanrossum merged 7 commits into
gvanrossum merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
gvanrossum
reviewed
Jun 9, 2017
Comment thread
src/test_typing.py
| yield 42 | ||
|
|
||
| cm = manager() | ||
| self.assertNotIsInstance(cm, typing.AsyncContextManager) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'd add a test that also serves as an example of how to use AsyncContextManager (presumably in async with ...?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I was planning to do this after AbstractAsyncContextManager is merged into CPython (python/cpython#1412), but there's really no need to wait. The code looks good to me. It would be nice if this can make it into 3.6.2. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks! |
Sorry, something went wrong.
JelleZijlstra
added a commit
to JelleZijlstra/typeshed
that referenced
this pull request
Jun 24, 2017
Implements: - python/typing#438 - python/cpython#360 python/cpython#1412, which adds contextlib.AbstractAsyncContextManager, has not yet been merged.
gvanrossum
pushed a commit
to python/typeshed
that referenced
this pull request
Jun 27, 2017
) Implements: - python/typing#438 - python/cpython#360 Note that python/cpython#1412, which adds contextlib.AbstractAsyncContextManager, has not yet been merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asynchronous context managers are defined by PEP 492, but there is no corresponding generic abstract class in typing. This PR adds it for Python 3.5+.