FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix ForwardRef hash and equality checks by rfrowe · Pull Request #704 · python/typing · GitHub

  1. python
  2. typing

Repository navigation

Fix ForwardRef hash and equality checks - #704

Merged
gvanrossum merged 1 commit into
python:masterfrom
rfrowe:forward-ref
Mar 6, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Fix ForwardRef hash and equality checks#704
gvanrossum merged 1 commit into
python:masterfrom
rfrowe:forward-ref

Conversation

rfrowe commented Mar 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This backports python/cpython#15400 to this typing module and fixes #667.

Ideally if we stick a ForwardRef in a dictionary we would like to reliably be able to get it out again.

https://bugs.python.org/issue37953
(cherry picked from commit e082e7c in python/cpython)

Co-authored-by: plokmijnuhby 39633434+plokmijnuhby@users.noreply.github.com

the-knights-who-say-ni commented Mar 2, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rfrowe

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

gvanrossum reviewed Mar 3, 2020
View reviewed changes
Comment thread src/test_typing.py Outdated
Fix ForwardRef hash and equality checks
8ea8b2e 
Ideally if we stick a ForwardRef in a dictionary we would like to reliably be able to get it out again.

https://bugs.python.org/issue37953
(cherry picked from commit e082e7c in python/cpython)

Co-authored-by: plokmijnuhby 39633434+plokmijnuhby@users.noreply.github.com
gvanrossum merged commit 15e5396 into python:master Mar 6, 2020

gvanrossum commented Mar 6, 2020

Copy link
Copy Markdown
Member

Thanks for your efforts! Is there anything else you're waiting for?

rfrowe commented Mar 6, 2020

Copy link
Copy Markdown
Contributor Author

Nope, that's it. Thanks for all of your help. Glad to be a part of the 3.7.7 release!

rfrowe deleted the forward-ref branch March 6, 2020 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum left review comments

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Infinite recursion with get_type_hints

3 participants

Back | FazBrowse Home | New Git URL