PEP 702: Runtime warnings - #112
Merged
JelleZijlstra merged 2 commits intoFeb 7, 2023
Merged
JelleZijlstra merged 2 commits into
JelleZijlstra merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
hauntsaninja
approved these changes
Feb 6, 2023
hauntsaninja
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
This looks great!
I was a little surprised by the choice of category=None as a way to spell no warning, since with warnings.warn, category=None is UserWarning. But I think it's fine, the behaviour will be clearly visible + the documentation will make clear that category=None will disable the warning.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
If you wanted, could add a test for a method as well |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See python/peps#3006.