Use typing_extensions.Literal for 3.8 due to unresolved bugs in CPython - #144
Closed
adriangb wants to merge 2 commits into
Closed
Use typing_extensions.Literal for 3.8 due to unresolved bugs in CPython#144adriangb wants to merge 2 commits into
adriangb wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This might need #113 to be resolved first |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Oh, I was actually already working on this! Here you go: |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Closing this in favor of your PR which is obviously better. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python/cpython#103592 (comment), cc @JelleZijlstra