Reimplement Literal on Python <=3.10.0 - #148
Merged
JelleZijlstra merged 2 commits intoApr 20, 2023
Merged
JelleZijlstra merged 2 commits into
JelleZijlstra merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
README.md
Outdated
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra
approved these changes
Apr 20, 2023
This was referenced May 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147.
No code changes are required -- the typing_extensions reimplementation of Literal has never suffered from the same bug that was fixed in python/cpython#29334, because we don't cache Literal subscripts in the same way that CPython does. (I think if we wanted to do so, it might require us to reimplement @typing._tp_cache as it exists on CPython main, since the signature of _tp_cache changed between bugfix versions at some point.) As such, all we need to do is reimplement Literal on <=3.10.0 instead of <=3.9.0.
Cc. @dfremont :)