Add __orig_bases__ to TypedDict by adriangb · Pull Request #150 · python/typing_extensions · GitHub

No description provided.

This should be up to date with the CPython change which just got merged

Thanks! Could you also add a CHANGELOG entry? Look at some of Alex's recent PRs for examples.

We need to change these lines so that we reimplement NamedTuple on <=3.11 rather than <=3.10. Otherwise call-based typing_extensions.NamedTuples will have __orig_bases__ on 3.7-3.10 and 3.12+, but not 3.11 😄

typing_extensions/src/typing_extensions.py

Lines 2316 to 2320 in fb37b2e

    
           # Backport typing.NamedTuple as it exists in Python 3.11. 
        
           # In 3.11, the ability to define generic `NamedTuple`s was supported. 
        
           # This was explicitly disallowed in 3.9-3.10, and only half-worked in <=3.8. 
        
           if sys.version_info >= (3, 11): 
        
               NamedTuple = typing.NamedTuple

test_typing_extensions_defers_when_possible will need to be adjusted as a result -- you'll need to move "NamedTuple" into the if sys.version_info < (3, 12) set here:

typing_extensions/src/test_typing_extensions.py

Lines 3610 to 3613 in fb37b2e

    
           if sys.version_info < (3, 11): 
        
               exclude |= {'final', 'NamedTuple', 'Any'} 
        
           if sys.version_info < (3, 12): 
        
               exclude |= {'Protocol', 'runtime_checkable', 'SupportsIndex'}

Could you also add a CHANGELOG entry?

Done, I copied Alex's changelog note from CPython.

I think it's important that we copy CPython's behaviour here, and CPython emits a deprecation warning here on 3.11+. This PR means we reimplement TypedDict on 3.11 now, so the change is needed, I think. @JelleZijlstra do you think we should only emit the deprecation warning if the user is running typing_extensions on 3.11+? (Referencing #150 (comment))

That's a hard question and gets into what we would do if we ever want to break backwards compatibility for typing-extensions. My first instinct is to say we should always warn in typing-extensions, regardless of the version, but then what would we do when CPython removes support for kwargs-based TypedDicts? I'd be hesitant to remove the runtime behavior in typing-extensions and break backwards compatibility.

I agree it's a hard question.

Elsewhere in the typing_extensions implementation of TypedDict, we actually already have two places where CPython long ago removed support for a certain feature, but typing_extensions has in effect had "eternal deprecation warnings":

typing_extensions/src/typing_extensions.py

Lines 789 to 791 in fb37b2e

    
           import warnings 
        
           warnings.warn("Passing '_typename' as keyword argument is deprecated", 
        
                         DeprecationWarning, stacklevel=2)

typing_extensions/src/typing_extensions.py

Lines 804 to 806 in fb37b2e

    
           import warnings 
        
           warnings.warn("Passing '_fields' as keyword argument is deprecated", 
        
                         DeprecationWarning, stacklevel=2)

I think eternal deprecation warnings might be the right answer, actually. (Or eternal until we ever make typing-extensions 5 in the distant uncertain future.)

So maybe we do want the change in #150 (comment)? ;)

Yes, let's do that. I commented there because the change looked unrelated to this PR.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

I filed adriangb#2 as a PR to your branch to address my comment above here: #150 (review)

Don't skip NamedTuple tests on 3.11+. Also make them pass on 3.11+.

Looks great to me!

Followup to python#150

Followup to #150

Co-authored-by: AlexWaygood <alex.waygood@gmail.com>

Followup to python#150

adriangb and others added 4 commits April 20, 2023 19:30

Add __orig_bases__ to TypedDict

c3a9e55

Fix tests

2e59a70

Merge pull request #1 from AlexWaygood/typeddict-bases

c94b79d

sync up with CPython PR

cdcccdd

JelleZijlstra reviewed Apr 23, 2023

View reviewed changes

Comment thread src/test_typing_extensions.py

AlexWaygood reviewed Apr 23, 2023

View reviewed changes

release note

ed6d0cf

AlexWaygood reviewed Apr 23, 2023

View reviewed changes

Comment thread CHANGELOG.md

adriangb and others added 2 commits April 23, 2023 13:12

Update CHANGELOG.md

2feff1e

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

Don't skip NamedTuple tests on 3.11+. Also make them pass on 3.11+.

42606d6

AlexWaygood mentioned this pull request Apr 24, 2023

Don't skip NamedTuple tests on 3.11+. Also make them pass on 3.11+. adriangb/typing_extensions#2

Merged

Merge pull request #2 from AlexWaygood/typeddict-bases

6365ab1

Don't skip NamedTuple tests on 3.11+. Also make them pass on 3.11+.

AlexWaygood approved these changes Apr 24, 2023

View reviewed changes

AlexWaygood mentioned this pull request Apr 24, 2023

Add a backport of types.get_original_bases #154

Merged

JelleZijlstra approved these changes Apr 24, 2023

View reviewed changes

Comment thread src/test_typing_extensions.py

Update src/test_typing_extensions.py

229df6e

JelleZijlstra merged commit 1f98818 into python:main Apr 24, 2023

AlexWaygood added a commit to AlexWaygood/typing_extensions that referenced this pull request Apr 24, 2023

README: Updates re NamedTuple and TypedDict

566e370

Followup to python#150

AlexWaygood mentioned this pull request Apr 24, 2023

README: Updates re NamedTuple and TypedDict #155

Merged

JelleZijlstra pushed a commit that referenced this pull request Apr 24, 2023

README: Updates re NamedTuple and TypedDict (#155 )

0273a6e

Followup to #150

adriangb mentioned this pull request Apr 25, 2023

Support configs, field validators and such on TypedDict pydantic/pydantic#5582

Closed

ShaneMurphy2 pushed a commit to ShaneMurphy2/typing_extensions that referenced this pull request May 17, 2023

Add __orig_bases__ to all TypedDict and NamedTuple (python#150 )

a95d6d7

Co-authored-by: AlexWaygood <alex.waygood@gmail.com>

ShaneMurphy2 pushed a commit to ShaneMurphy2/typing_extensions that referenced this pull request May 17, 2023

README: Updates re NamedTuple and TypedDict (python#155 )

4c939ae

Followup to python#150

	# Backport typing.NamedTuple as it exists in Python 3.11.
	# In 3.11, the ability to define generic `NamedTuple`s was supported.
	# This was explicitly disallowed in 3.9-3.10, and only half-worked in <=3.8.
	if sys.version_info >= (3, 11):
	NamedTuple = typing.NamedTuple

	if sys.version_info < (3, 11):
	exclude \|= {'final', 'NamedTuple', 'Any'}
	if sys.version_info < (3, 12):
	exclude \|= {'Protocol', 'runtime_checkable', 'SupportsIndex'}

                                           " but not both")
+                      if kwargs:
+                          warnings.warn(

	import warnings
	warnings.warn("Passing '_typename' as keyword argument is deprecated",
	DeprecationWarning, stacklevel=2)

	import warnings
	warnings.warn("Passing '_fields' as keyword argument is deprecated",
	DeprecationWarning, stacklevel=2)

Add __orig_bases__ to TypedDict by adriangb · Pull Request #150 · python/typing_extensions · GitHub

Uh oh!

Uh oh!

Add __orig_bases__ to TypedDict - #150

Add __orig_bases__ to TypedDict#150JelleZijlstra merged 9 commits intopython:mainpython/typing_extensions:mainfrom adriangb:typeddict-basesadriangb/typing_extensions:typeddict-basesCopy head branch name to clipboard

Conversation

adriangb commented Apr 21, 2023

Uh oh!

adriangb commented Apr 23, 2023

Uh oh!

JelleZijlstra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexWaygood left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adriangb commented Apr 23, 2023

Uh oh!

AlexWaygood Apr 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra Apr 23, 2023

Choose a reason for hiding this comment

Uh oh!

AlexWaygood Apr 23, 2023

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra Apr 23, 2023

Choose a reason for hiding this comment

Uh oh!

AlexWaygood Apr 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra Apr 23, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexWaygood commented Apr 24, 2023

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add __orig_bases__ to TypedDict#150
JelleZijlstra merged 9 commits into
python:mainfrom
adriangb:typeddict-bases

AlexWaygood left a comment •
edited
Loading

AlexWaygood Apr 23, 2023 •
edited
Loading

AlexWaygood Apr 23, 2023 •
edited
Loading