More fixes for 3.14 and 3.15 - #602
Merged
JelleZijlstra merged 2 commits intoMay 24, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
srittau
reviewed
May 24, 2025
Comment thread
src/test_typing_extensions.py
Comment on lines
+4407
to
+4419
| def _make_td(future, class_name, annos, base, extra_names=None): | ||
| lines = [] | ||
| if future: | ||
| lines.append('from __future__ import annotations') | ||
| lines.append('from typing import TypedDict') | ||
| lines.append(f'class {class_name}({base}):') | ||
| for name, anno in annos.items(): | ||
| lines.append(f' {name}: {anno}') | ||
| code = '\n'.join(lines) | ||
| ns = {**extra_names} if extra_names else {} | ||
| exec(code, ns) | ||
| return ns[class_name] | ||
|
|
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
This is all very magical. Wouldn't it make more sense to just hard-code these four fairly short code samples?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Ah, it's eight. So maybe use a template at least?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I feel that would be more complicated; it would require conditionals on half the lines of the template and textwrap.dedent.
Sorry, something went wrong.
srittau
approved these changes
May 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python/cpython#133772 (TypedDict change)
python/cpython#133822 (NamedTuple change for 3.15)