| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
nice, thank you!
Sorry, something went wrong.
The Python 3.10+ implementation started raising in PR#165
|
Thanks for the review! I pushed a few changes. re: making ParamSpec.__init_subclass__ raise in the 3.9 implementation, would this be worth a changelog mention? For reference, the 3.10+ implementation started raising in #165, which didn't include a changelog entry |
Sorry, something went wrong.
There was a problem hiding this comment.
making ParamSpec.init_subclass raise in the 3.9 implementation, would this be worth a changelog mention? For reference, the 3.10+ implementation started raising in #165, which didn't include a changelog entry.
Imo, it's worth noting. That it is now consistent with the other versions.
Sorry, something went wrong.
Probably worth it, just to be safe? I feel like #165 probably should have had a changelog mention too if it changed behaviour 😄 |
Sorry, something went wrong.
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Co-authored-by: Daraan <github.blurry@9ox.net>
There was a problem hiding this comment.
Looks great! I think there's a merge conflict
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Add tests to exercise some previously unexercised lines: