Fix error message when subclassing TypeVarTuple - #679
Open
JanEricNitschke wants to merge 9 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #679 +/- ##
==========================================
- Coverage 97.39% 97.39% -0.01%
==========================================
Files 3 3
Lines 7767 7793 +26
==========================================
+ Hits 7565 7590 +25
- Misses 202 203 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
Comment thread
src/typing_extensions.py
Outdated
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Comment thread
CHANGELOG.md
Outdated
Copy link
Copy Markdown
Member
|
@copilot resolve the merge conflicts in this pull request |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Anything i can/should still do here? Conflict is only in the changelog. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue discovered by running CPython 3.12 test_typing.py on typing_extensions: https://github.com/JanEricNitschke/typing_extensions/actions/runs/17692936537/job/50288896717#step:7:120
Test from here: https://github.com/python/cpython/blob/main/Lib/test/test_typing.py#L1526
Regex from here (adjusted to also handle typing_extensions): https://github.com/python/cpython/blob/main/Lib/test/test_typing.py#L61