FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make TypeAliasType __module__ writable by ericmarkmartin · Pull Request #744 · python/typing_extensions · GitHub

  1. python
  2. typing_extensions

Repository navigation

Make TypeAliasType __module__ writable - #744

Merged
JelleZijlstra merged 4 commits into
python:mainfrom
ericmarkmartin:typealiastype-writable-module
May 3, 2026
ConversationCommits (4)ChecksFiles changed
Merged

Make TypeAliasType __module__ writable#744
JelleZijlstra merged 4 commits into
python:mainfrom
ericmarkmartin:typealiastype-writable-module

Conversation

ericmarkmartin commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

ericmarkmartin mentioned this pull request Apr 30, 2026
Closed

ericmarkmartin commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

I still need to add a changelog entry here

codecov Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.38%. Comparing base (f7dbe27) to head (9cfad2a).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
- Coverage   97.39%   97.38%   -0.02%     
==========================================
  Files           3        3              
  Lines        7767     7768       +1     
==========================================
  Hits         7565     7565              
- Misses        202      203       +1
Flag Coverage Δ
3.10 89.08% <100.00%> (+<0.01%) ⬆️
3.10.4 89.08% <100.00%> (+<0.01%) ⬆️
3.11 88.32% <100.00%> (+<0.01%) ⬆️
3.11.0 87.56% <100.00%> (+<0.01%) ⬆️
3.12 88.27% <100.00%> (+<0.01%) ⬆️
3.12.0 88.25% <100.00%> (+<0.01%) ⬆️
3.13 81.83% <100.00%> (+<0.01%) ⬆️
3.13.0 82.55% <100.00%> (+<0.01%) ⬆️
3.14 79.12% <100.00%> (+0.84%) ⬆️
3.9 89.78% <100.00%> (+<0.01%) ⬆️
3.9.12 89.78% <100.00%> (+<0.01%) ⬆️
pypy3.10 88.91% <100.00%> (+<0.01%) ⬆️
pypy3.11 88.18% <100.00%> (+<0.01%) ⬆️
pypy3.9 89.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/test_typing_extensions.py 98.41% <100.00%> (+<0.01%) ⬆️
src/typing_extensions.py 93.92% <100.00%> (-0.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ericmarkmartin force-pushed the typealiastype-writable-module branch 2 times, most recently from 332c96a to 4214724 Compare April 30, 2026 21:26
JelleZijlstra approved these changes May 1, 2026
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, but going to wait until the CPython PR lands

JelleZijlstra commented May 1, 2026

Copy link
Copy Markdown
Member

One more tests needs updating

ericmarkmartin force-pushed the typealiastype-writable-module branch from 4214724 to 21ae390 Compare May 1, 2026 19:01

ericmarkmartin commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

One more tests needs updating

Should be fixed!

JelleZijlstra merged commit 2f06414 into python:main May 3, 2026
24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL