Fix stringified bare ClassVar type hints - #782
Open
Sanjays2402 wants to merge 1 commit into
Open
Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Python 3.9 and 3.10 reject a bare ClassVar while evaluating a ForwardRef, so get_type_hints() raises for postponed annotations. Evaluate class annotations through the newer class-aware path and allow the bare ClassVar special form, with coverage for inherited hints. Fixes python#643
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #782 +/- ##
=======================================
Coverage 97.26% 97.27%
=======================================
Files 3 3
Lines 7860 7885 +25
=======================================
+ Hits 7645 7670 +25
Misses 215 215
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Python 3.9 and 3.10, get_type_hints() treats a stringified bare ClassVar as a forward reference and rejects it with TypeError. This backports the class-aware evaluation behavior for ClassVar and adds coverage for inherited annotations.
Fixes #643.