Support default type parameters in Generic - #795
Open
GruffElixir wants to merge 3 commits into
Open
GruffElixir wants to merge 3 commits into
GruffElixir wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #795 +/- ##
==========================================
- Coverage 97.26% 97.24% -0.03%
==========================================
Files 3 3
Lines 7859 7905 +46
==========================================
+ Hits 7644 7687 +43
- Misses 215 218 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #672
On Python 3.9–3.12, typing's generic specialization path does not invoke the default-substitution hooks exposed by typing_extensions.TypeVar. Apply those hooks for generic classes and aliases before delegating to typing, so omitted parameters use their declared defaults.
Tests: Python 3.9 and 3.10 python -m unittest test_typing_extensions.TypeVarLikeDefaultsTests; Python 3.14 same.