FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support list format fallbacks by akx · Pull Request #1099 · python-babel/babel · GitHub

  1. python-babel
  2. babel

Repository navigation

Support list format fallbacks - #1099

Merged
akx merged 3 commits into
masterfrom
issue-1098
Jul 15, 2024
ConversationCommits (3)ChecksFiles changed
Merged

Support list format fallbacks#1099
akx merged 3 commits into
masterfrom
issue-1098

Conversation

akx commented Jul 11, 2024

Copy link
Copy Markdown
Member

Fixes #1098 by fixing one part of #1076.

As noted in the TODO comment, this isn't the optimal way to implement it, but a better way could be swapped in later.

akx marked this pull request as ready for review July 12, 2024 06:10

akx commented Jul 12, 2024

Copy link
Copy Markdown
Member Author

Cc @Vexed01 for reporting #1098.

Cc @tomasr8 if you feel like taking a quick look!

akx mentioned this pull request Jul 12, 2024
Closed
1 of 7 tasks
tomasr8 approved these changes Jul 12, 2024
View reviewed changes

tomasr8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me :) Full branch and statement coverage for babel.lists as well

As an aside, I was looking for some description for how the list patterns are defined in the XML and I only found this short explanation. I assume the <listPattern> with no type is the standard one?

akx commented Jul 15, 2024

Copy link
Copy Markdown
Member Author

As an aside, I was looking for some description for how the list patterns are defined in the XML and I only found this short explanation. I assume the <listPattern> with no type is the standard one?

It's (vaguely) in the TR35 doc:

"type attribute value": standard (or no type)

akx merged commit 7394c37 into master Jul 15, 2024
akx deleted the issue-1098 branch April 20, 2026 05:56
AryanRG mentioned this pull request Oct 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
tomasr8 tomasr8 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/CLDR bug enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

babel.lists.format_list with style="unit" errors on non-English languages

2 participants

Back | FazBrowse Home | New Git URL