Repository navigation
Use canonical IANA zone names in zone_territories - #1220
akx merged 1 commit into
Conversation
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1220 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 27 27
Lines 4692 4692
=======================================
Hits 4320 4320
Misses 372 372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
|
@anentropic Please review if you have time :) |
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Updates how timezone data is imported and tested so that the canonical IANA IDs are used for zone_territories while preserving aliases.
- Combined and extended the legacy test_get_global into test_zone_aliases_and_territories to verify both alias and canonical lookups.
- Modified parse_global in import_cldr.py to prefer the iana attribute for tzid, skip deprecated entries, and more robustly derive territory mappings.
- Adjusted territory resolution to fall back through aliases rather than relying solely on the primary alias.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_core.py | Replaced test_get_global with a broader test covering aliases and canonical zones. |
| scripts/import_cldr.py | Updated parse_global to use iana attribute, skip deprecated, and refine territory lookup. |
Sorry, something went wrong.
|
the results in test_core look good to me 👍 |
Sorry, something went wrong.
Refs #1218, should fix it.
There's an iana="..." attribute in (at least recent) timezone XML files, but we historically never read that and instead just trusted the first alias to be the canonical tzid.