Implement parsing of default command configuration from pyproject.toml - #1290
Open
max-moser wants to merge 1 commit into
Open
Implement parsing of default command configuration from pyproject.toml#1290max-moser wants to merge 1 commit into
max-moser wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
max-moser
force-pushed
the
mm/pyproject-config
branch
from
65a5cdb to
ceb1f4b
Compare
July 7, 2026 14:34
If present, use a "pyproject.toml" file for default configuration of `pybabel` commands.
max-moser
force-pushed
the
mm/pyproject-config
branch
from
ceb1f4b to
511f10d
Compare
July 11, 2026 08:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should close #777
This PR adds support of pyproject.toml as a source for default configuration values for the various CLI commands (compile, extract, init, update).
The configuration will be read from pyproject.toml, under the [tool.babel.<command_name>] table, where <command_name> is one of compile_catalog, extract_messages, init_catalog, update_catalog (taken from frontend_setuptools).
The motivation for this PR here is that I've recently migrated most of the inveniosoftware packages from setuptools to hatchling and we included the old configuration from setup.cfg in pyproject.toml, only to find that pybabel doesn't actually read any command config from pyproject.toml 😅
(Luckily for us that was only a minor issue in one package that we fixed otherwise)
The mechanism for finding pyproject.toml is similar to that used in other tools, like isort.
I could also imagine adding a global CLI flag for disabling reading pyproject.toml altogether, or for letting users specify another TOML config file instead.
The parsed values are inserted as default values for the optparse parser, so user-provided CLI flags should still take precedence.
Please let me know if this goes in an acceptable direction, then I can polish up the implementation a bit 🙂