Repository navigation
Sort MO indexes by encoded context and message keys - #1374
Open
fhgffy wants to merge 1 commit into
Open
fhgffy wants to merge 1 commit into
fhgffy wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MO files require the original-string table to be sorted by its encoded lookup keys. Sorting Message objects orders msgid before context, which can emit an unsorted table when messages have contexts. Babel does not emit a hash table, so binary-search readers depend on this ordering.
Sort the existing descriptors by their serialized context/singular keys before writing the parallel original and translation indexes. Add a regression that checks the emitted tables and translation correspondence with UTF-8 and cp1252 contexts and plural messages.
Validation: the new regression fails on the original source; all 6 MO tests and the complete suite (7,829 passed, 10 skipped, 2 xfailed) pass after the fix. Project Ruff and whitespace/debug hooks and sdist/wheel builds passed.
Specification: https://www.gnu.org/software/gettext/manual/html_node/MO-Files.html