Repository navigation
Preserve apostrophes in quoted number patterns - #1380
Open
Boulea7 wants to merge 1 commit into
Open
Boulea7 wants to merge 1 commit into
Boulea7 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Decode doubled apostrophes inside quoted pattern affixes and unquote the selected prefix and suffix separately from generated number symbols. This preserves ASCII apostrophe grouping in locales such as fr_CH. Keep currency substitution before unquoting, and cover quoted affixes, grouping, and adjacent currency placeholders with regression tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doubled apostrophes inside quoted affixes are currently lost: format_decimal(1, "0'kg''s'", locale="en_US") returns 1kgs instead of 1kg's. Unquoting the complete output also removes the ASCII grouping separators from format_decimal(1234567, "#,##0", locale="fr_CH"), producing 1234567 instead of 1'234'567.
Unquote the selected prefix and suffix separately from the generated number, preserving the existing currency-substitution order. Regression tests cover quoted positive and negative affixes, currency placeholders, and apostrophe grouping.
Validation on Python 3.11 with CLDR 48.2: numbers tests (151 passed), full suite (7851 passed, 7 skipped, 2 xfailed), Ruff, and an installed-wheel smoke test.