Repository navigation
numbers: Preserve quoted semicolons in patterns - #1382
Open
himanshu748 wants to merge 1 commit into
Open
himanshu748 wants to merge 1 commit into
himanshu748 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Split positive and negative number subpatterns only at an unquoted semicolon. Quoted semicolons belong to the displayed affix, including when an explicit negative subpattern follows. Cover literal prefixes and suffixes, doubled quotes, and both signs.
himanshu748
marked this pull request as ready for review
October 14, 2026 16:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_pattern() currently splits positive and negative subpatterns at the first semicolon, including semicolons inside a quoted literal. For example, format_decimal(12, "0';'", locale='en') should return 12;.
Find the first unquoted semicolon instead, preserving quoted literal prefixes and suffixes. Add eight parametrized cases covering both signs, explicit negative subpatterns, doubled apostrophes, and an ordinary unquoted separator.
Validation recorded in the 12 October 2026 handoff on Linux with the project's checksum-verified CLDR 48.2 data:
The isolated environments needed the tzdata package and process-scoped TZ=UTC for unrelated timezone tests. The existing TOML parametrization deprecation warning remains. Other Python versions and operating systems were not run; upstream CI and maintainer review remain pending.
AI assistance: Codex assisted with this contribution and regression validation.