FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Validate Locale parameter formats while constructing by akx · Pull Request #309 · python-babel/babel · GitHub

  1. python-babel
  2. babel

Repository navigation

Validate Locale parameter formats while constructing - #309

Open
akx wants to merge 2 commits into
python-babel:masterfrom
akx:validate-locale-ctor
ConversationCommits (2)ChecksFiles changed
Open

Validate Locale parameter formats while constructing#309
akx wants to merge 2 commits into
python-babel:masterfrom
akx:validate-locale-ctor

Conversation

akx commented Dec 30, 2015

Copy link
Copy Markdown
Member

This avoids being able to construct mongrel locales with language = 'en_US', territory = None.

Fixes #283

⚠️ Warning ⚠️

This might actually be a fairly disruptive change to the users of the library who have come to expect they can build locales with Locale("en_US").

codecov-io commented Dec 30, 2015

Copy link
Copy Markdown

Current coverage is 89.49%

Merging #309 into master will increase coverage by +0.09% as of 51fd1f3

@@            master    #309   diff @@
======================================
  Files           23      23       
  Stmts         3736    3752    +16
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           3340    3358    +18
  Partial          0       0       
+ Missed         396     394     -2

Review entire Coverage Diff as of 51fd1f3

Powered by Codecov. Updated on successful CI builds.

akx added this to the Babel 2.3/3.0 milestone Jan 3, 2016
akx force-pushed the validate-locale-ctor branch 2 times, most recently from 6cb6101 to 98a786d Compare January 11, 2016 10:04

akx commented Jan 11, 2016

Copy link
Copy Markdown
Member Author

Come to think of it, this paves the way nicely for #30; we can now derive a FuzzyLocale class or similar that doesn't validate as strictly. :)

akx force-pushed the validate-locale-ctor branch from 98a786d to cf47d0a Compare January 11, 2016 11:03
akx mentioned this pull request Jan 14, 2016
Open

danjamesmay commented Jan 14, 2016

Copy link
Copy Markdown

akx:
Come to think of it, this paves the way nicely for #30; we can now derive a FuzzyLocale class or similar > that doesn't validate as strictly. :)

Is there some kind of roadmap as to when fuzzy locales will be implemented? I have a requirement that needs the ability to define custom/fuzzy locales, so it would be great to know when I can implement this.

akx force-pushed the validate-locale-ctor branch from cf47d0a to b1ff3da Compare January 23, 2016 20:00
akx removed this from the Babel 2.3 milestone Feb 3, 2016

akx commented Feb 3, 2016

Copy link
Copy Markdown
Member Author

Moved this out of the next point release due to the warning above.

akx added this to the Babel 3 milestone Apr 25, 2016

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pending review size/M

Projects

None yet

Milestone

Babel 3

Development

Successfully merging this pull request may close these issues.

Locale __init__/parse inconsistencies

5 participants

Back | FazBrowse Home | New Git URL