Repository navigation
Extract Python messages in nested gettext calls - #488
Merged
akx merged 4 commits intoMar 31, 2017
Merged
akx merged 4 commits into
akx merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
==========================================
+ Coverage 90.16% 90.17% +<.01%
==========================================
Files 24 24
Lines 3975 3978 +3
==========================================
+ Hits 3584 3587 +3
Misses 391 391
Continue to review full report at Codecov.
|
Sorry, something went wrong.
akx
approved these changes
Mar 31, 2017
akx
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Beautifully simple modification to the extractor, and a great test case 🎉
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes #487.
There're only one small change and complex test cases.