Initial Android Support: alternate - #280
Open
victorpaleologue wants to merge 7 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
It was not effective, and it was visible using Android Studio.
Translated to CMake from a patch on the Yocto project: http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-devtools/python/python3/0002-Don-t-do-runtime-test-to-get-float-byte-order.patch?h=zeus It avoids the execution of a program on the target device, and produces a clearer endianness result.
It avoids the need for checking it by running a program on the target platform.
…piling They are already present in source releases, so it is possible to ignore the regeneration step. We do that only when cross-compiling, because it is not possible to build for both the host and the target with a single pass of CMake.
Copy link
Copy Markdown
|
Nice, I'll try it later, but Fix floating point endianness checks helped to fix them on Github Actions Android emulator. Locally I got: -- Checking for x64 gcc inline assembler -- Checking for x64 gcc inline assembler - yes -- Checking whether C doubles are little-endian IEEE 754 binary64 -- Checking whether C doubles are little-endian IEEE 754 binary64 - yes -- Checking whether C doubles are big-endian IEEE 754 binary64 -- Checking whether C doubles are big-endian IEEE 754 binary64 - no -- Checking doubles are ARM mixed-endian IEEE 754 binary64 -- Checking doubles are ARM mixed-endian IEEE 754 binary64 - no -- Checking whether we can use gcc inline assembler to get and set x87 control word -- Checking whether we can use gcc inline assembler to get and set x87 control word - yes But in Github Actions I got: -- Checking for x64 gcc inline assembler -- Checking for x64 gcc inline assembler - yes -- Checking whether C doubles are little-endian IEEE 754 binary64 -- Checking whether C doubles are little-endian IEEE 754 binary64 - yes -- Checking whether C doubles are big-endian IEEE 754 binary64 -- Checking whether C doubles are big-endian IEEE 754 binary64 - yes -- Checking doubles are ARM mixed-endian IEEE 754 binary64 -- Checking doubles are ARM mixed-endian IEEE 754 binary64 - yes -- Checking whether we can use gcc inline assembler to get and set x87 control word -- Checking whether we can use gcc inline assembler to get and set x87 control word - yes |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@victorpaleologue Thanks for working on the Android support 🙏 and thanks @o01eg for reviewing. Working on the backlog of pull request, is there anything else from #262 that we should add here ? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@jcfr I suppose it could be useful to add Github Actions CI build here at least. |
Sorry, something went wrong.
This was referenced Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have been using the branch by @o01eg to build Python for Android (from this PR: #262) and managed to make it work with some extra changes.
I hope this set of changes will be interesting as well.
To avoid requiring to connect to a target device while building (which is hard to achieve on simpler buildfarms), I had to provide certain definitions manually. I tested the build with the following definitions: