FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

MacOS: skip bundled libffi on non-x86_64 by bjia56 · Pull Request #342 · python-cmake-buildsystem/python-cmake-buildsystem · GitHub

/ python-cmake-buildsystem Public

MacOS: skip bundled libffi on non-x86_64 - #342

Open
bjia56 wants to merge 3 commits into
python-cmake-buildsystem:masterfrom
bjia56:macos-arm64
ConversationCommits (3)ChecksFiles changed
Open

MacOS: skip bundled libffi on non-x86_64#342
bjia56 wants to merge 3 commits into
python-cmake-buildsystem:masterfrom
bjia56:macos-arm64

Conversation

bjia56 commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

When cross compiling for arm64 Macs, the bundled cpython libffi throws an unsupported cpu error. This change makes it so that Mac compilation skips the bundled libffi if a system libffi was requested.

This change also now makes it possible to build universal python binaries for x86_64/arm64, though that also requires pre-compiling dependencies (including libffi) from source for both architectures.

bjia56 commented Sep 27, 2023

Copy link
Copy Markdown
Contributor Author

I see from the CI tests that this ended up disabling ctypes on regular x86_64 macos, will tweak to restore prior behavior.

bjia56 changed the title MacOS: skip bundled libffi if a system one is provided MacOS: skip bundled libffi on non-x86_64 Sep 27, 2023
bjia56 mentioned this pull request Dec 19, 2023
Closed

theartful commented Sep 14, 2025

Copy link
Copy Markdown

What's the status on this? I was about to do a PR doing exactly the same thing, but then found out you already did it.

theartful reviewed Sep 14, 2025
View reviewed changes
Comment thread cmake/extensions/CMakeLists.txt
${SRC_DIR}/Modules/_ctypes/darwin
DEFINITIONS MACOSX
)
if(CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" AND CMAKE_OSX_ARCHITECTURES STREQUAL "x86_64")

theartful Sep 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm testing this PR, and trying to build python on an arm macos for x86_64, and then for arm64 (I made a wrong review that I deleted before, disregard it if you saw it).

I failed locally to build for x86_64 on an arm machine (ctypes didn't work), since I get CMAKE_SYSTEM_PROCESSOR = arm64, while CMAKE_OSX_ARCHITECTURES = x86_64.

I think it's better to check only for CMAKE_OSX_ARCHITECTURES

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
theartful theartful left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL