Fix ty unresolved-attribute warnings and add mypy back by tleonhardt · Pull Request #1737 · python-cmd2/cmd2 · GitHub

Add mypy back in addition to ty for type checking.

Also fixes ty unresolved-attribute warnings and stop globally ignoring them within ty.toml.

Major changes:

Add mypy back so now both ty and mypy are used for type checking - each are better at some things
Convert BoundCommandFunc and UnboundCommandFunc TypeAliases in types.py to Protocol classes for stricter type checking
Added _CommandFunc type alias in annotated.py based on BoundCommandFunc and UnboundCommandFunc
Used getattr and/or cast() to help resolve some type errors in cmd2.py

Minor changes:

Added type ignore for ty:unresolved-attribute to a number of places we were already ignoring attr-defined for mypy (problem of different name for same type of check)

Major changes: - Convert BoundCommandFunc and UnboundCommandFunc TypeAliases in types.py to Protocol classes for stricter type checking - Added `_NamedCallable` Protocol class in annotated.py for stricter type checking of function references - Used `getattr` and/or `cast()` to help resolve some type errors in cmd2.py Minor changes: - Added type ignore for `ty:unresolved-attribute` to a number of places we were already ignoring `attr-defined` for mypy (problem of different name for same type of check)

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.64%. Comparing base (5dcbcbe) to head (a9fa36a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1737      +/-   ##
==========================================
- Coverage   99.66%   99.64%   -0.02%     
==========================================
  Files          23       23              
  Lines        5937     5960      +23     
==========================================
+ Hits         5917     5939      +22     
- Misses         20       21       +1

Flag	Coverage Δ
unittests	99.64% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Changes include: 1. Removed _NamedCallable: Deleted the redundant protocol class definition of _NamedCallable from cmd2/annotated.py. 2. Imported type protocols: Imported BoundCommandFunc and UnboundCommandFunc from cmd2/types.py, and TypeAlias from typing. 3. Defined unified _CommandFunc alias: Formed a private, unified type alias _CommandFunc = BoundCommandFunc | UnboundCommandFunc[CmdOrSetT, [argparse.Namespace]]. 4. Updated function signatures: Replaced all annotations that previously used _NamedCallable in cmd2/annotated.py with _CommandFunc.

@KelvinChung2000 Could you please review the changes in annotated.py? There this is mostly replacing every Callable[..., Any] type hint with a type alias: _CommandFunc: TypeAlias = BoundCommandFunc | UnboundCommandFunc[CmdOrSetT, Any] so it is more in line with type hints elsewhere in the codebase.

@kmvanbrunt Could you please review changes outside of annotated.py? For this there are two main changes:

Account for ty calling what mypy called attr-defined, unresolved-attribute instead.
Converted BoundCommandFunc and UnboundCommandFunc from simple type alias to Protocol classes which do a better job of type hinting that certain attributes have to exist (duck typing)

…ommandFunc Protocol classes Also: - Switched some types in cmd2.py from `Callable[..., Any]` to `BoundCommandFunc` - Removed a number of `cast` calls in cmd2.py which were no longer needed

…unc and UnboundCommand func Also: - Restored the simple attribute definition for `__name__` attribute in BoundCommandFunc and UnboundCommandFund

…asts

…ntation Deleted _CommandFunc from annotated.py and replaced with BoundCommandFunc from types.py

…ction to make some types less restrictive

It turns out that ty is better at some things and mypy is better at others when it comes to type checking. So ty is at least not yet a purely superior replacement for mypy.

Most modern agent harness CLIs like codex, agy, opencode, hemes, pi, oh-my-pi, and tau all read AGENTS.md by default. It has emerged as the single file used by most agentic AI tools. Leaving GEMINI.md in place for now since Gemini CLI doesn't read AGENTS.md by default.

…ed.py

@KelvinChung2000 @kmvanbrunt Ok, I think this is ready for another review.

I ended up adding mypy back to our type checking in addition to ty because each of them are stricter about checking some things than the other.

…tions

Also: - Reword a couple TypeError messages which read awkwardly

tleonhardt self-assigned this Aug 26, 2026

tleonhardt requested a review from kmvanbrunt as a code owner August 26, 2026 02:30

tleonhardt added 3 commits August 25, 2026 22:59

Fixed typo

ec7745e

Fix type alias

59455b6

tleonhardt requested a review from KelvinChung2000 August 26, 2026 03:37

KelvinChung2000 previously approved these changes Aug 26, 2026

View reviewed changes

Made __name__ a read-only propery for BoundCommandFunc and UnboundC…

c19c018

…ommandFunc Protocol classes Also: - Switched some types in cmd2.py from `Callable[..., Any]` to `BoundCommandFunc` - Removed a number of `cast` calls in cmd2.py which were no longer needed

tleonhardt dismissed KelvinChung2000’s stale review via c19c018 August 26, 2026 22:40

Made the owner parameter for __get__ optional in both BoundCommandF…

06e806a

…unc and UnboundCommand func Also: - Restored the simple attribute definition for `__name__` attribute in BoundCommandFunc and UnboundCommandFund

kmvanbrunt reviewed Aug 27, 2026

View reviewed changes

Comment thread cmd2/types.py Outdated

kmvanbrunt requested changes Aug 27, 2026

View reviewed changes

kmvanbrunt reviewed Aug 27, 2026

View reviewed changes

Comment thread cmd2/annotated.py Outdated

kmvanbrunt requested changes Aug 27, 2026

View reviewed changes

tleonhardt added 10 commits August 27, 2026 19:03

Remove unecessary ... and slight bump of ruff version

87bb1f2

Make types in annotated.py fully consistent

5ed78e9

Implemented protcol class in annotated.py to match needs and remove c…

557a11e

…asts

Realized that _CommandFunc and BoundCommandFunc had identical impleme…

242e768

…ntation Deleted _CommandFunc from annotated.py and replaced with BoundCommandFunc from types.py

Update CHANGELOG

5163c2d

Define _CommandFunc to represent either a Bound or Ubound command fun…

c35de2b

…ction to make some types less restrictive

Add mypy back in addition to ty for type checking and fix warnings

c0b5891

It turns out that ty is better at some things and mypy is better at others when it comes to type checking. So ty is at least not yet a purely superior replacement for mypy.

Fix types in annotated.py so both mypy and ty pass

383c04e

Updated AGENTS.ai so it doesn't refer to Gemini

11bc20c

tleonhardt changed the title Fix ty unresolved-attribute warnings and stop globally ignoring them Fix ty unresolved-attribute warnings and add mypy back Aug 28, 2026

tleonhardt added 2 commits August 28, 2026 19:26

Fix some type annotations so that cast is no longer needed in annotat…

89b9804

…ed.py

Fixed some types so an Any return type wasn't required

53ff2ed

Added tests to cover the missing lines in annotated.py

9699b2b

Removed a couple cast() calls which were no longer needed

77cd8ee

KelvinChung2000 reviewed Aug 29, 2026

View reviewed changes

Comment thread cmd2/annotated.py Outdated

tleonhardt added 4 commits August 29, 2026 13:55

Re-ordered some code so that quotes are not needed around type annota…

705f2ba

…tions

Add a missing check and associated unit test

de4ba20

Also: - Reword a couple TypeError messages which read awkwardly

Ruggedize a few types

e7dac06

Make __name__ and __qualname__ read-only properties in protocol classes

a9fa36a

tleonhardt merged commit 6191df8 into main Aug 29, 2026
28 of 29 checks passed

tleonhardt deleted the ty-unresolved-attribute branch August 29, 2026 23:29

Fix ty unresolved-attribute warnings and add mypy back by tleonhardt · Pull Request #1737 · python-cmd2/cmd2 · GitHub

Uh oh!

Fix ty unresolved-attribute warnings and add mypy back - #1737

Fix ty unresolved-attribute warnings and add mypy back#1737
tleonhardt merged 24 commits into
mainfrom
ty-unresolved-attribute

tleonhardt commented Aug 26, 2026 •
edited
Loading

Uh oh!

Uh oh!

codecov Bot commented Aug 26, 2026 •
edited
Loading

Uh oh!

Uh oh!

tleonhardt commented Aug 26, 2026

Uh oh!

Uh oh!

Uh oh!

tleonhardt commented Aug 29, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix ty unresolved-attribute warnings and add mypy back by tleonhardt · Pull Request #1737 · python-cmd2/cmd2 · GitHub

Uh oh!

Fix ty unresolved-attribute warnings and add mypy back - #1737

Fix ty unresolved-attribute warnings and add mypy back#1737tleonhardt merged 24 commits intomainpython-cmd2/cmd2:mainfrom ty-unresolved-attributepython-cmd2/cmd2:ty-unresolved-attributeCopy head branch name to clipboard

Conversation

tleonhardt commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tleonhardt commented Aug 26, 2026

Uh oh!

Uh oh!

Uh oh!

tleonhardt commented Aug 29, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix ty unresolved-attribute warnings and add mypy back#1737
tleonhardt merged 24 commits into
mainfrom
ty-unresolved-attribute

tleonhardt commented Aug 26, 2026 •
edited
Loading

codecov Bot commented Aug 26, 2026 •
edited
Loading