| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
The test failure looks interesting, seems to be here: Lines 53 to 54 in 395e058 not surprising since it seems like that was intended to be a private method. Maybe replacing it with pkgutil.resolve_name will fix it? (python/cpython#18544) |
Sorry, something went wrong.
I had actually forgotten about this PR. one other option we had discussed the other day was monkey patching it by including it in our testing utils. We'd likely want to avoid that if there's another way that can do this out of the box. |
Sorry, something went wrong.
Yeah, this is intended to be like this. That's where I got the original code from, and it used to use that internal method. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, tested and seems to work.
Two test warnings are raised due to this:
bot-hu2rt1Uv-py3.11\Lib\site-packages\feedparser\encodings.py:29: DeprecationWarning: 'cgi' is deprecated and slated for removal in Python 3.13
import cgi
The issue tracking that is kurtmckee/feedparser#330, it seems it was already fixed (kurtmckee/feedparser@ed8c762) and is just waiting on a release.
bot-hu2rt1Uv-py3.11\Lib\site-packages\discord\player.py:28: DeprecationWarning: 'audioop' is deprecated and slated for removal in Python 3.13
import audioop
The usage seems to be here: https://github.com/Rapptz/discord.py/blob/bb7668f8a58ba4b8161edeb77f8936ff807d6537/discord/player.py#L632
Given neither of them are issues currently I'm not sure they need to block this. I'll let you merge since you may need to relock first.
Sorry, something went wrong.
This also bumps some dev deps to latest
mock._importer was removed in 3.11
| Back | FazBrowse Home | New Git URL |
This updates the python version that the bot runs on to 3.11