FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Duplicated code in gitlab/config.py · Issue #1094 · python-gitlab/python-gitlab · GitHub

Repository navigation

Duplicated code in gitlab/config.py #1094

Description

Description of the problem, including code/CLI snippet

Duplicated code found in gitlab/config.py . I think one should be get from 'global'.

        self.http_username = None
        self.http_password = None
        try:
            self.http_username = self._config.get(self.gitlab_id, "http_username")
            self.http_password = self._config.get(self.gitlab_id, "http_password")
        except Exception:
            pass

        self.http_username = None
        self.http_password = None
        try:
            self.http_username = self._config.get(self.gitlab_id, "http_username")
            self.http_password = self._config.get(self.gitlab_id, "http_password")
        except Exception:
            pass

Expected Behavior

Actual Behavior

Specifications

  • python-gitlab version: python-gitlab==2.2.0
  • API version you are using (v3/v4): v4
  • Gitlab server version (or gitlab.com):

Activity

  1. max-wittig commented on May 12, 2020

    Member

    I will take a look soon.

  2. self-assigned this
    on May 12, 2020
  3. added a commit that references this issue on May 16, 2020
    ee2df6f
  4. locked as resolved and limited conversation to collaborators on Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


    Back | FazBrowse Home | New Git URL