Repository navigation
Tests need to be implemented for tests/unit/test_projects.py #1708
Description
Activity
I would like to work on this @JohnVillalovos .
Reacted by Nejc HabjanReacted by Nejc HabjanThat's amazing @vishalpandeyvip. I've assigned this to you for now, feel free to reach out if you have any issues/questions.
As we add new resources, we sometimes split modules to keep them a sane size, so it's possible some of those tests will eventually belong in a separate module, but up to you.
Reacted by Vishal PandeyThanks for assigning this to me @nejch . I am new to the project so once going through documentation and codebase. I will try to create a PR very soon.
Hello, I tried to implement some tests for the easy list functions in projects. Can you take a quick look into and give me some feedback? I pushed it to a forked Repository: rnoberger/python-gitlab
The fixtures are getting quickly big. Do you prefere to use the assert_all_requests_are_fired=False flag?
That looks good @rnoberger, thanks for taking a look at this! It's best to open a draft pull request so we can discuss it there :)
It looks mature enough for a PR already IMO. I think we can reduce the size of fixtures by using lazy=True in the initial project get() call (or even using a project fixture, I'll give you a suggestion), so we only need to mock the final request.
@vishalpandeyvip are you still interested in covering some of the other missing tests or should I unassign you from here?
That's awesome @antoineauger, thanks! Maybe one day we get to that magical 100% then 😁
Reacted by Antoine Auger- locked as resolved and limited conversation to collaborators on Jul 3, 2023
Currently we have a lot of unimplemented tests in tests/unit/test_projects.py.
Adding these tests would be a good first issue for someone to work on.
Comment below if you would like to work on this issue.