FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: increase projects coverage by rnoberger · Pull Request #2012 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

test: increase projects coverage - #2012

Merged
nejch merged 1 commit into
python-gitlab:mainfrom
rnoberger:rnoberger/test-projects
May 10, 2022
ConversationCommits (1)ChecksFiles changed
Merged

test: increase projects coverage#2012
nejch merged 1 commit into
python-gitlab:mainfrom
rnoberger:rnoberger/test-projects

Conversation

rnoberger commented May 8, 2022

Copy link
Copy Markdown
Contributor

No description provided.

rnoberger changed the title test: increase projects coverage #1708 test: increase projects coverage May 8, 2022
rnoberger mentioned this pull request May 8, 2022
Closed

codecov-commenter commented May 8, 2022 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.66%. Comparing base (ef207da) to head (fa47829).
⚠️ Report is 1012 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2012      +/-   ##
==========================================
+ Coverage   92.58%   92.66%   +0.07%     
==========================================
  Files          78       78              
  Lines        4938     4949      +11     
==========================================
+ Hits         4572     4586      +14     
+ Misses        366      363       -3
Flag Coverage Δ
cli_func_v4 81.39% <ø> (-0.11%) ⬇️
py_func_v4 80.33% <ø> (-0.16%) ⬇️
unit 83.63% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nejch requested changes May 8, 2022
View reviewed changes

nejch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks a lot for the PR @rnoberger. I've added the comments on how to reduce the fixture boilerplate as discussed, let me know if anything's unclear.

If applying the suggestions in the UI just make sure to change the commit message on GitHub or amend it later to match our convention :) Thanks!

Comment thread tests/unit/objects/test_projects.py Outdated
Comment thread tests/unit/objects/test_projects.py Outdated
Comment thread tests/unit/objects/test_projects.py Outdated
Comment thread tests/unit/objects/test_projects.py Outdated
Comment thread tests/unit/objects/test_projects.py Outdated
Comment thread tests/unit/objects/test_projects.py Outdated
Comment thread tests/unit/objects/test_projects.py Outdated
Comment thread tests/unit/objects/test_projects.py Outdated
Comment thread tests/unit/objects/test_projects.py Outdated
Comment thread tests/unit/objects/test_projects.py Outdated
rnoberger force-pushed the rnoberger/test-projects branch from 0ba035b to fa47829 Compare May 10, 2022 20:06
nejch approved these changes May 10, 2022
View reviewed changes

nejch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for working on this @rnoberger, let us know in case you want to continue working on other parts and need any help :)

nejch merged commit fd9154e into python-gitlab:main May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nejch nejch approved these changes

Assignees

rnoberger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL