FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Warn user when detecting misconfigured server `external_url`? · Issue #1978 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

Warn user when detecting misconfigured server external_url? #1978

Closed
#2222
Closed
Warn user when detecting misconfigured server external_url?#1978
#2222
Labels
enhancement

Description

nejch
opened on Apr 20, 2022

As seen in #1977, #1934 and older issues, paginated list() calls will fail when the server's external URL is not configured properly because we trust the links headers returned by the GitLab server:

python-gitlab/gitlab/client.py

Line 1060 in d27cc6a

next_url = links["next"]["url"]

Maybe we should warn (or fail explicitly) if we detect the base url differs from the URL advertised back by the server?

(Just to avoid new issues popping up every now and then)

Activity

  1. nejch
    added
    enhancement
    on Apr 20, 2022

  2. JohnVillalovos commented on Apr 20, 2022

    JohnVillalovos
    on Apr 20, 2022
    Member

    Sounds like a good idea. Maybe create an FAQ item to point to.

  3. nejch commented on Jul 9, 2022

    nejch
    on Jul 9, 2022
    MemberAuthor

    User error in URL config could also potentially be detected by this, which is what seems to have happened in #2130 where a gitlab instance is served in a subdirectory on the domain.

  4. JohnVillalovos
    closed this as completedin #2222on Aug 4, 2022
  5. github-actions
    locked as resolved and limited conversation to collaborators on Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      Back | FazBrowse Home | New Git URL