Codecov Report

Merging #1290 (faa421d) into master (48fc907) will increase coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
+ Coverage   79.92%   79.95%   +0.02%     
==========================================
  Files          73       73              
  Lines        4010     4016       +6     
==========================================
+ Hits         3205     3211       +6     
  Misses        805      805              

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fc907...faa421d. Read the comment docs.

What do you think about having an optional _arg_name attribute that could be put on classes. If that was present using that as the argument name, otherwise use the what_to_cls function.

FYI: These classes seem like ones to fail before this patch.

CurrentUserGPGKey
current-user-gp-gkey

LDAPGroup
l-da-pgroup

UserGPGKey
user-gp-gkey

What do you think about having an optional _arg_name attribute that could be put on classes. If that was present using that as the argument name, otherwise use the what_to_cls function.

Here is a Proof-of-Concept for this:
#1362

What do you think about having an optional _arg_name attribute that could be put on classes. If that was present using that as the argument name, otherwise use the what_to_cls function.

I actually did this whole namespace lookup dance so that we wouldn't need to manually maintain another attribute in case people forget about it when adding new features 😅 but maybe your approach is clearer. I haven't looked at whether the current approach is problematic for typing. Either way I'll rebase and add some more tests. :)

Codecov Report

Merging #1290 (8cf5031) into master (f35c73e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
+ Coverage   90.82%   90.83%   +0.01%     
==========================================
  Files          73       73              
  Lines        4020     4027       +7     
==========================================
+ Hits         3651     3658       +7     
  Misses        369      369              

Flags with carried forward coverage won't be shown. Click here to find out more.

@JohnVillalovos I just rebased, could you take one last look and merge if it's ok? :)

Based on some other discussions on (not) manually maintaining too many object attributes I think #1362 can be closed if this is merged, WDYT?

Looks good to me @nejch Thanks.