Repository navigation
Implement slack integration service. - #135
Closed
marcoblos wants to merge 5 commits into
Closed
marcoblos wants to merge 5 commits into
marcoblos wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for this patch, but I'm afraid it breaks the CRUD logic that is used with other objects. I'd prefer to see a new ProjectSlackService class (or similar, that's just an idea) to manage the other methods (create/update/get/delete). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Support for services has been added. Thanks. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@gpocentek Thank's for add this feature and sorry for don't response you, i am very busy in last days. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement method to put a new integration with Slack.
project.slack_service('https://hooks.slack.com/services/...', 'optional-username', '#optional-channel')
If not inform username and channel assumes the configured the slack service.