FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(base): allow persisting local attributes when updating object by nejch · Pull Request #1443 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

fix(base): allow persisting local attributes when updating object - #1443

Closed
nejch wants to merge 1 commit into
masterfrom
fix/persist-attributes-on-save
ConversationCommits (1)ChecksFiles changed
Closed

fix(base): allow persisting local attributes when updating object#1443
nejch wants to merge 1 commit into
masterfrom
fix/persist-attributes-on-save

Conversation

nejch commented May 2, 2021

Copy link
Copy Markdown
Member

Related to #1395.

codecov-commenter commented May 2, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1443 (796c700) into master (b563cdc) will increase coverage by 0.00%.
The diff coverage is 81.81%.

@@           Coverage Diff           @@
##           master    #1443   +/-   ##
=======================================
  Coverage   80.24%   80.24%           
=======================================
  Files          73       73           
  Lines        4064     4081   +17     
=======================================
+ Hits         3261     3275   +14     
- Misses        803      806    +3
Flag Coverage Δ
unit 80.24% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/mixins.py 77.13% <66.66%> (-0.25%) ⬇️
gitlab/base.py 88.88% <100.00%> (+0.28%) ⬆️
gitlab/types.py 90.00% <0.00%> (-2.60%) ⬇️
gitlab/exceptions.py 96.52% <0.00%> (-1.30%) ⬇️
gitlab/__main__.py 0.00% <0.00%> (ø)
gitlab/cli.py 56.36% <0.00%> (+2.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b563cdc...796c700. Read the comment docs.

nejch mentioned this pull request May 2, 2021
Closed

max-wittig commented May 3, 2021

Copy link
Copy Markdown
Member

I'm not sure, if this makes sense. python-gitlab should be a light wrapper around the GitLab API. If we start adding more custom things (other than the required ones e.g. lazy) that might become less maintainable and maybe also confusing for the users? WDYT?

nejch commented May 6, 2021

Copy link
Copy Markdown
Member Author

Closing this in favor of #1448 as discussed.

nejch closed this May 6, 2021
nejch deleted the fix/persist-attributes-on-save branch May 30, 2021 08:25
nejch mentioned this pull request Jun 9, 2021
Merged
nejch mentioned this pull request Dec 23, 2021
Closed
nejch mentioned this pull request May 5, 2022
Open
nejch mentioned this pull request Sep 15, 2022
Closed
nejch restored the fix/persist-attributes-on-save branch September 15, 2022 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL