FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: rename 'tools/functional/' to 'tests/functional/' by JohnVillalovos · Pull Request #1469 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

chore: rename 'tools/functional/' to 'tests/functional/' - #1469

Merged
nejch merged 1 commit into
python-gitlab:masterfrom
JohnVillalovos:jlvillal/test_directory
May 26, 2021
ConversationCommits (1)ChecksFiles changed
Merged

chore: rename 'tools/functional/' to 'tests/functional/'#1469
nejch merged 1 commit into
python-gitlab:masterfrom
JohnVillalovos:jlvillal/test_directory

Conversation

JohnVillalovos commented May 26, 2021

Copy link
Copy Markdown
Member

Rename the 'tools/functional/' directory to 'tests/functional/'

This makes more sense as these are functional tests and not tools.

JohnVillalovos marked this pull request as draft May 26, 2021 00:36
JohnVillalovos requested a review from nejch May 26, 2021 00:47
JohnVillalovos marked this pull request as ready for review May 26, 2021 00:47

codecov-commenter commented May 26, 2021 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.91%. Comparing base (9beff0d) to head (502715d).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1469   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files          73       73           
  Lines        4051     4051           
=======================================
  Hits         3683     3683           
  Misses        368      368
Flag Coverage Δ
cli_func_v4 80.47% <ø> (ø)
py_func_v4 79.78% <ø> (ø)
unit 82.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nejch requested changes May 26, 2021
View reviewed changes

nejch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks John! Could you also change the paths in the renovate config:

python-gitlab/.renovaterc.json

Line 7 in eabe091

"fileMatch": ["^tools/functional/fixtures/.env$"],

And the Manifest (especially if we move unit tests there also):

python-gitlab/MANIFEST.in

Line 3 in eabe091

recursive-include tools *

chore: rename 'tools/functional/' to 'tests/functional/'
502715d 
Rename the 'tools/functional/' directory to 'tests/functional/'

This makes more sense as these are functional tests and not tools.

This was dicussed in:
#1468

JohnVillalovos commented May 26, 2021

Copy link
Copy Markdown
Member Author

Thanks John! Could you also change the paths in the renovate config:

python-gitlab/.renovaterc.json

Line 7 in eabe091

"fileMatch": ["^tools/functional/fixtures/.env$"],

And the Manifest (especially if we move unit tests there also):

python-gitlab/MANIFEST.in

Line 3 in eabe091

recursive-include tools *

Done! Thanks.

nejch merged commit 90ecf2f into python-gitlab:master May 26, 2021
JohnVillalovos deleted the jlvillal/test_directory branch May 26, 2021 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nejch nejch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL