Repository navigation
chore: use built-in function issubclass() instead of getmro() - #1481
Merged
nejch merged 1 commit intoMay 29, 2021
Merged
nejch merged 1 commit into
nejch merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JohnVillalovos
marked this pull request as draft
May 28, 2021 21:17
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
- Coverage 90.91% 90.91% -0.01%
==========================================
Files 73 73
Lines 4051 4049 -2
==========================================
- Hits 3683 3681 -2
Misses 368 368
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
Code was using inspect.getmro() to replicate the functionality of the built-in function issubclass() Switch to using issubclass()
JohnVillalovos
marked this pull request as ready for review
May 28, 2021 22:35
nejch
reviewed
May 29, 2021
nejch
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks. Looking at this reminds me there's a lot of V3 cruft left in the code (like this try/except). Just one little question :)
Sorry, something went wrong.
Comment thread
gitlab/v4/cli.py
nejch
approved these changes
May 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code was using inspect.getmro() to replicate the functionality of the
built-in function issubclass()
Switch to using issubclass()