Codecov Report

Merging #1628 (d989c9b) into main (4170dbe) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1628   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          74       74           
  Lines        4295     4295           
=======================================
  Hits         3948     3948           
  Misses        347      347           

Flags with carried forward coverage won't be shown. Click here to find out more.

Funny, looks like there were actually some unit tests written that mocked POST/DELETE responses to the group runner. I'll check if this might be an undocumented API in gitlab already..

Funny, looks like there were actually some unit tests written that mocked POST/DELETE responses to the group runner. I'll check if this might be an undocumented API in gitlab already..

@lgatellier I think you can safely delete the following to make it pass:

https://github.com/python-gitlab/python-gitlab/blob/master/tests/unit/objects/test_runners.py#L255-L256

and

https://github.com/python-gitlab/python-gitlab/blob/master/tests/unit/objects/test_runners.py#L266-L270

as real GitLab servers would not work with this.

I removed the 2 test cases.
I think mocked responses related to enabling/disabling runner should be changed to remove "groups" from URI pattern.
Can you confirm that ?

@pytest.fixture
def resp_runner_enable():
    with responses.RequestsMock() as rsps:
        pattern = re.compile(r".*?(projects|groups)/1/runners")

@pytest.fixture
def resp_runner_disable():
    with responses.RequestsMock() as rsps:
        pattern = re.compile(r".*?/(groups|projects)/1/runners/6")

I removed the 2 test cases. I think mocked responses related to enabling/disabling runner should be changed to remove "groups" from URI pattern. Can you confirm that ?

@pytest.fixture
def resp_runner_enable():
    with responses.RequestsMock() as rsps:
        pattern = re.compile(r".*?(projects|groups)/1/runners")

@pytest.fixture
def resp_runner_disable():
    with responses.RequestsMock() as rsps:
        pattern = re.compile(r".*?/(groups|projects)/1/runners/6")

That's right @lgatellier, thank you!

@lgatellier would you mind rebasing this onto the main branch?

@nejch all done, mocked responses are fixed, and branch is rebased !

Thanks again @lgatellier!