FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(docs):API delete key example by bengaywins · Pull Request #1638 · python-gitlab/python-gitlab · GitHub

Repository navigation

fix(docs):API delete key example - #1638

Merged
JohnVillalovos merged 1 commit into
python-gitlab:mainfrom
bengaywins:main
Oct 12, 2021
Merged

JohnVillalovos merged 1 commit into
python-gitlab:mainfrom
bengaywins:main

Conversation

Copy link
Copy Markdown

Closes #1637

bengaywins changed the title Fix API delete key example fix(docs):API delete key example Oct 12, 2021

Copy link
Copy Markdown
Member

The commit message will need to be like:

docs: fix API delete key example

Copy link
Copy Markdown
Author

Ah I was trying to make sense of that. Just pushed again with docs: prefix.

Copy link
Copy Markdown
Member

Ah I was trying to make sense of that. Just pushed again with docs: prefix.

I think it catches everyone the first time.

I actually do a git log to remind myself of the format 😏

Copy link
Copy Markdown
Author

must not be sentence-case, start-case, pascal-case, upper-case

Does this mean that the entire commit message must be all lowercase?

Copy link
Copy Markdown
Member

must not be sentence-case, start-case, pascal-case, upper-case

Does this mean that the entire commit message must be all lowercase?

No. Just the first letter after the colon. Try the message I suggested above. I believe that will work.

Copy link
Copy Markdown
Author

Awesome just pushed with said commit message.

Copy link
Copy Markdown
Author

Also really appreciate the help @JohnVillalovos!

Comment thread docs/gl_objects/deploy_keys.rst Outdated

Copy link
Copy Markdown
Member

Thanks! LGTM (Looks Good To Me).

JohnVillalovos enabled auto-merge (rebase) October 12, 2021 18:00

codecov-commenter commented Oct 12, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1638 (7adab7a) into main (4eb8ec8) will decrease coverage by 3.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
- Coverage   91.90%   88.01%   -3.90%     
==========================================
  Files          74       74              
  Lines        4287     4287              
==========================================
- Hits         3940     3773     -167     
- Misses        347      514     +167     
Flag Coverage Δ
cli_func_v4 81.89% <ø> (ø)
py_func_v4 ?
unit 83.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/files.py 61.76% <0.00%> (-30.89%) ⬇️
gitlab/v4/objects/milestones.py 71.42% <0.00%> (-28.58%) ⬇️
gitlab/utils.py 65.51% <0.00%> (-24.14%) ⬇️
gitlab/v4/objects/repositories.py 57.62% <0.00%> (-23.73%) ⬇️
gitlab/v4/objects/sidekiq.py 80.95% <0.00%> (-19.05%) ⬇️
gitlab/v4/objects/commits.py 78.87% <0.00%> (-15.50%) ⬇️
gitlab/v4/objects/clusters.py 85.71% <0.00%> (-14.29%) ⬇️
gitlab/v4/objects/snippets.py 83.72% <0.00%> (-13.96%) ⬇️
gitlab/v4/objects/environments.py 88.23% <0.00%> (-11.77%) ⬇️
gitlab/v4/objects/merge_requests.py 76.19% <0.00%> (-9.53%) ⬇️
... and 10 more

JohnVillalovos merged commit b31bb05 into python-gitlab:main Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Documentation bug

3 participants


Back | FazBrowse Home | New Git URL