Repository navigation
chore: add initial pylint check - #1729
Merged
nejch merged 3 commits intoDec 7, 2021
Merged
nejch merged 3 commits into
nejch merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JohnVillalovos
force-pushed
the
jlvillal/pylint
branch
from
9a9c10a to
ddc24be
Compare
December 5, 2021 21:34
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 92.03% 92.03% -0.01%
==========================================
Files 75 75
Lines 4683 4681 -2
==========================================
- Hits 4310 4308 -2
Misses 373 373
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
JohnVillalovos
force-pushed
the
jlvillal/pylint
branch
from
ddc24be to
df93b20
Compare
December 6, 2021 01:04
nejch
reviewed
Dec 7, 2021
Comment thread
.github/workflows/lint.yml
JohnVillalovos
force-pushed
the
jlvillal/pylint
branch
from
df93b20 to
da5f43f
Compare
December 7, 2021 16:40
nejch
reviewed
Dec 7, 2021
Comment thread
.pre-commit-config.yaml
JohnVillalovos
force-pushed
the
jlvillal/pylint
branch
10 times, most recently
from
de14dea to
5f35250
Compare
December 7, 2021 18:51
nejch
reviewed
Dec 7, 2021
Comment thread
.pre-commit-config.yaml
JohnVillalovos
force-pushed
the
jlvillal/pylint
branch
3 times, most recently
from
dde09fc to
168d2ab
Compare
December 7, 2021 22:17
Initial pylint check is added. A LONG list of disabled checks is also added. In the future we should work through the list and resolve the errors or disable them on a more granular level.
If .pre-commit-config.yaml or .github/workflows/pre_commit.yml are updated then run pre-commit.
JohnVillalovos
force-pushed
the
jlvillal/pylint
branch
7 times, most recently
from
cb61379 to
645ef1f
Compare
December 7, 2021 23:07
https://github.com/pre-commit/mirrors-mypy/blob/master/.pre-commit-hooks.yaml Sets some default args which seem to be interfering with things. Plus we set all of our args in the `pyproject.toml` file.
JohnVillalovos
force-pushed
the
jlvillal/pylint
branch
from
645ef1f to
b67a6ad
Compare
December 7, 2021 23:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial pylint check is added. A LONG list of disabled checks is also
added. In the future we should work through the list and resolve the
errors or disable them on a more granular level.