Repository navigation
feat(cli): do not require config file to run CLI - #1743
nejch merged 1 commit into
Conversation
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## main #1743 +/- ##
==========================================
- Coverage 91.97% 91.97% -0.01%
==========================================
Files 76 76
Lines 4737 4759 +22
==========================================
+ Hits 4357 4377 +20
- Misses 380 382 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
JohnVillalovos
left a comment
There was a problem hiding this comment.
Can functional tests be added for this. In particular a functional test that demonstrates it works without a config file? Though I guess that will try to contact https://gitlab.com/ 😟
Sorry, something went wrong.
BREAKING CHANGE: A config file is no longer needed to run the CLI. python-gitlab will default to https://gitlab.com with no authentication if there is no config file provided. python-gitlab will now also only look for configuration in the provided PYTHON_GITLAB_CFG path, instead of merging it with user- and system-wide config files. If the environment variable is defined and the file cannot be opened, python-gitlab will now explicitly fail.
JohnVillalovos
left a comment
There was a problem hiding this comment.
Looks good to me. I wasn't sure if you wanted to merge it or not.
Please merge whenever you are ready.
Thanks.
Sorry, something went wrong.
BREAKING CHANGE: A config file is no longer needed to run
the CLI. python-gitlab will default to https://gitlab.com
with no authentication if there is no config file provided.
python-gitlab will now also only look for configuration
in the provided PYTHON_GITLAB_CFG path, instead of merging
it with user- and system-wide config files. If the
environment variable is defined and the file cannot be
opened, python-gitlab will now explicitly fail.
Needed for #1296