FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: add logging to `tests/functional/conftest.py` by JohnVillalovos · Pull Request #1786 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

chore: add logging to tests/functional/conftest.py - #1786

Merged
nejch merged 1 commit into
mainfrom
jlvillal/logging
Jan 9, 2022
ConversationCommits (1)ChecksFiles changed
Merged

chore: add logging to tests/functional/conftest.py#1786
nejch merged 1 commit into
mainfrom
jlvillal/logging

Conversation

JohnVillalovos commented Dec 30, 2021

Copy link
Copy Markdown
Member

I have found trying to debug issues in the functional tests can be
difficult. Especially when trying to figure out failures in the CI
running on Github.

Add logging to tests/functional/conftest.py to have a better
understanding of what is happening during a test run which is useful
when trying to troubleshoot issues in the CI.

JohnVillalovos marked this pull request as draft December 30, 2021 05:17
JohnVillalovos marked this pull request as ready for review December 30, 2021 05:42
nejch reviewed Dec 30, 2021
View reviewed changes
Comment thread pyproject.toml Outdated
JohnVillalovos force-pushed the jlvillal/logging branch 2 times, most recently from 93967ee to 2dd8fdb Compare December 30, 2021 18:11
JohnVillalovos requested a review from nejch December 30, 2021 19:39
JohnVillalovos force-pushed the jlvillal/logging branch 4 times, most recently from 87b6150 to 5ab8b3f Compare January 4, 2022 05:44
nejch reviewed Jan 6, 2022
View reviewed changes

nejch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @JohnVillalovos! Just a few comments for discussion from me.

I have found trying to debug issues in the functional tests can be difficult. Especially when trying to figure out failures in the CI running on Github.

Add logging to tests/functional/conftest.py to have a better understanding of what is happening during a test run which is useful when trying to troubleshoot issues in the CI.

Just a note here, I prefer debugging locally as otherwise watchers can get spammed with notifications on many pushes. But I understand sometimes it's CI-only issues and then it's hard to debug so this makes sense.

Comment thread tests/functional/conftest.py
Comment thread pyproject.toml Outdated
Comment thread tox.ini Outdated
Comment thread tests/functional/conftest.py Outdated
Comment thread tests/functional/conftest.py Outdated
Comment thread tests/functional/conftest.py
Comment thread tests/functional/conftest.py Outdated
Comment thread tests/functional/conftest.py Outdated

JohnVillalovos commented Jan 7, 2022

Copy link
Copy Markdown
Member Author

Just a note here, I prefer debugging locally as otherwise watchers can get spammed with notifications on many pushes. But I understand sometimes it's CI-only issues and then it's hard to debug so this makes sense.

I personally have found this quite useful for local debugging too. I like having a progress indication for one. Even though it doesn't give me an ETA at least I know it is doing something.

JohnVillalovos force-pushed the jlvillal/logging branch 2 times, most recently from 089e84a to aa1e458 Compare January 7, 2022 06:51
JohnVillalovos requested a review from nejch January 7, 2022 07:08
chore: add logging to tests/functional/conftest.py
a1ac9ae 
I have found trying to debug issues in the functional tests can be
difficult. Especially when trying to figure out failures in the CI
running on Github.

Add logging to `tests/functional/conftest.py` to have a better
understanding of what is happening during a test run which is useful
when trying to troubleshoot issues in the CI.
nejch merged commit ac81272 into main Jan 9, 2022
nejch deleted the jlvillal/logging branch January 9, 2022 01:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nejch Awaiting requested review from nejch

Assignees

JohnVillalovos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL