Repository navigation
fix(cli): url-encode path components of the URL - #1790
Merged
nejch merged 2 commits intoJan 8, 2022
Merged
nejch merged 2 commits into
nejch merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## main #1790 +/- ##
==========================================
+ Coverage 92.02% 92.03% +0.01%
==========================================
Files 76 76
Lines 4790 4798 +8
==========================================
+ Hits 4408 4416 +8
Misses 382 382
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
JohnVillalovos
force-pushed
the
jlvillal/parent_attrs
branch
from
d7ee0cb to
ae97e4d
Compare
January 2, 2022 01:10
JohnVillalovos
force-pushed
the
jlvillal/parent_attrs
branch
2 times, most recently
from
f2cc3cf to
3a75d87
Compare
January 4, 2022 05:44
nejch
reviewed
Jan 6, 2022
JohnVillalovos
force-pushed
the
jlvillal/parent_attrs
branch
from
3a75d87 to
3243735
Compare
January 7, 2022 01:15
JohnVillalovos
force-pushed
the
jlvillal/parent_attrs
branch
from
3243735 to
4b779bd
Compare
January 8, 2022 21:07
nejch
requested changes
Jan 8, 2022
nejch
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks John. Just a few suggestions and could you maybe rename the commit message to say fix(cli): ... so that it's parsed as a scope?
Sorry, something went wrong.
Comment thread
gitlab/v4/cli.py
Outdated
Comment thread
tests/functional/cli/test_cli_variables.py
Outdated
Comment thread
tests/functional/cli/test_cli_variables.py
Outdated
Comment thread
gitlab/v4/cli.py
Outdated
Comment thread
tests/functional/cli/test_cli_variables.py
Outdated
Previously c8256a5 was done to fix this but it missed two other failures.
JohnVillalovos
force-pushed
the
jlvillal/parent_attrs
branch
from
4b779bd to
79b1cc0
Compare
January 8, 2022 22:18
In the CLI we need to make sure the components put into the path portion of the URL are url-encoded. Otherwise they will be interpreted as part of the path. For example can specify the project ID as a path, but in the URL it must be url-encoded or it doesn't work. Also stop adding the components of the path as query parameters in the URL. Closes: #783 Closes: #1498
JohnVillalovos
force-pushed
the
jlvillal/parent_attrs
branch
from
79b1cc0 to
ac1c619
Compare
January 8, 2022 22:24
Copy link
Copy Markdown
Member
Author
Done! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the CLI we need to make sure the components put into the path
portion of the URL are url-encoded. Otherwise they will be interpreted
as part of the path. For example can specify the project ID as a path,
but in the URL it must be url-encoded or it doesn't work.
Also stop adding the components of the path as query parameters in the
URL.
Closes: #783
Closes: #1498