Repository navigation
fix: remove default arguments for mergerequests.merge() - #1818
nejch merged 1 commit into
Conversation
Sorry, something went wrong.
The arguments `should_remove_source_branch` and `merge_when_pipeline_succeeds` are optional arguments. We should not be setting any default value for them. https://docs.gitlab.com/ee/api/merge_requests.html#accept-mr Closes: #1750
Codecov Report
@@ Coverage Diff @@
## main #1818 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 76 76
Lines 4799 4799
=======================================
Hits 4416 4416
Misses 383 383
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
|
As we see in the functional tests this is technically a breaking behavior. But only in the scenarios where In this case, python-gitlab used to override the project default due to its own default (which was False). But IMO this is wrong and unexpected behavior from python-gitlab, so I think we can get away with a fix here 👍 For anyone reading this after the fact, the merge() default was added years before the project-level setting was introduced, so as soon as GitLab introduced the project-level setting our client started to have wrong behavior and it doesn't make sense anymore. |
Sorry, something went wrong.
|
@nejch I agree. As it is very confusing if the project default is set to remove it but then we are by default not removing it. |
Sorry, something went wrong.
The arguments should_remove_source_branch and
merge_when_pipeline_succeeds are optional arguments. We should not
be setting any default value for them.
https://docs.gitlab.com/ee/api/merge_requests.html#accept-mr
Closes: #1750