FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: Update issue example and extend API usage by MichaelSweikata · Pull Request #2022 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

docs: Update issue example and extend API usage - #2022

Merged
nejch merged 1 commit into
python-gitlab:mainfrom
MichaelSweikata:feat/documentation-update
May 23, 2022
ConversationCommits (1)ChecksFiles changed
Merged

docs: Update issue example and extend API usage#2022
nejch merged 1 commit into
python-gitlab:mainfrom
MichaelSweikata:feat/documentation-update

Conversation

MichaelSweikata commented May 17, 2022

Copy link
Copy Markdown

Updates to the documentation to include changes on the Gitlab API for assignee_ids, and explicitly reference how to extend an object for attributes not explicitly mentioned.

JohnVillalovos requested changes May 17, 2022
View reviewed changes
Comment thread docs/api-usage.rst Outdated

JohnVillalovos commented May 17, 2022

Copy link
Copy Markdown
Member

Looks good to me. Just one minor issue. Thanks!

JohnVillalovos commented May 23, 2022

Copy link
Copy Markdown
Member

@MichaelSweikata Looks good but can you squash the four commits down to one commit?

MichaelSweikata commented May 23, 2022

Copy link
Copy Markdown
Author

@MichaelSweikata Looks good but can you squash the four commits down to one commit?

I'll do my best to figure out how, sorry, still new at this part!

JohnVillalovos commented May 23, 2022

Copy link
Copy Markdown
Member

@MichaelSweikata Looks good but can you squash the four commits down to one commit?

I'll do my best to figure out how, sorry, still new at this part!

I found some info here. https://www.git-tower.com/learn/git/faq/git-squash/

But if you like I can try to squash them for you.

nejch force-pushed the feat/documentation-update branch from 331a931 to aad71d2 Compare May 23, 2022 22:10

nejch commented May 23, 2022

Copy link
Copy Markdown
Member

As we already have a LGTM by @JohnVillalovos here I pushed a squashed commit instead of doing a new one in #2025 to keep the history here, hope that's ok with you both :)

nejch enabled auto-merge May 23, 2022 22:15
nejch merged commit 792cee9 into python-gitlab:main May 23, 2022

JohnVillalovos commented May 23, 2022

Copy link
Copy Markdown
Member

As we already have a LGTM by @JohnVillalovos here I pushed a squashed commit instead of doing a new one in #2025 to keep the history here, hope that's ok with you both :)

Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JohnVillalovos JohnVillalovos requested changes
nejch nejch approved these changes

Assignees

MichaelSweikata

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL