Repository navigation
chore: enable more pylint checks - #2051
Merged
nejch merged 7 commits intoJun 5, 2022
Merged
nejch merged 7 commits into
nejch merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JohnVillalovos
marked this pull request as draft
June 3, 2022 23:49
Enable the pylint checks: * unnecessary-pass * unspecified-encoding Update code to resolve errors found
Enabled the pylint checks that don't require any code changes. Previously these checks were disabled.
Enable the pylint check "raise-missing-from" and fix errors detected.
Enable the pylint check: "attribute-defined-outside-init" and fix errors detected.
Enable the pylint check "no-else-return" and fix the errors detected.
Enable the pylint check "no-self-use" and fix the errors detected.
Enable the pylint check "redefined-outer-name" and fix the errors detected.
JohnVillalovos
force-pushed
the
jlvillal/more_more_pylint
branch
from
7ca7a00 to
1324ce1
Compare
June 4, 2022 16:18
JohnVillalovos
marked this pull request as ready for review
June 4, 2022 16:28
Copy link
Copy Markdown
Member
Author
|
@nejch Let me know if you would prefer this split into multiple PRs. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
It's ok, LGTM! pylint complaining about attribute-defined-outside-init for rest objects IMO is a bit dubious in our case, as we already abuse instance attributes for API attributes. That will always be a moving target, but let's see :) |
Sorry, something went wrong.
nejch
approved these changes
Jun 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.