Repository navigation
fix(cli): handle list response for json/yaml output - #2290
Merged
nejch merged 1 commit intoOct 6, 2022
Merged
nejch merged 1 commit into
nejch merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JohnVillalovos
force-pushed
the
jlvillal/fix_json_yaml_list
branch
from
46b091f to
e8b18a5
Compare
September 30, 2022 21:08
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2290 +/- ##
==========================================
+ Coverage 95.29% 95.31% +0.01%
==========================================
Files 79 79
Lines 5246 5246
==========================================
+ Hits 4999 5000 +1
+ Misses 247 246 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
JohnVillalovos
force-pushed
the
jlvillal/fix_json_yaml_list
branch
2 times, most recently
from
6500602 to
e4409ca
Compare
October 4, 2022 04:29
nejch
reviewed
Oct 4, 2022
nejch
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice fix @JohnVillalovos! Just a quick question on tests as I'm seeing some more repetition now the sidekiq handling.
Sorry, something went wrong.
Comment thread
tests/functional/cli/test_cli_repository.py
Outdated
Comment thread
tests/functional/cli/test_cli_repository.py
Outdated
Comment thread
tests/functional/cli/test_cli_repository.py
JohnVillalovos
force-pushed
the
jlvillal/fix_json_yaml_list
branch
from
e4409ca to
cd9695d
Compare
October 5, 2022 02:11
Handle the case with the CLI where a list response is returned from GitLab and json/yaml output is requested. Add a functional CLI test to validate it works. Closes: #2287
JohnVillalovos
force-pushed
the
jlvillal/fix_json_yaml_list
branch
from
cd9695d to
fbc0ecb
Compare
October 5, 2022 14:43
nejch
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the case with the CLI where a list response is returned from GitLab and json/yaml output is requested.
Closes: #2287