FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Changelog: improve Changelog & convert to Markdown by GhostLyrics · Pull Request #230 · python-gitlab/python-gitlab · GitHub

Repository navigation

Changelog: improve Changelog & convert to Markdown - #230

Merged
gpocentek merged 1 commit into
python-gitlab:masterfrom
GhostLyrics:master
Mar 9, 2017
Merged

gpocentek merged 1 commit into
python-gitlab:masterfrom
GhostLyrics:master

Conversation

Copy link
Copy Markdown
Contributor

I hope that you like what I did to the Changelog and are not offended I chose not to use RST for this, but the comparison links didn't seem well suited for what I could find about RST's link syntax.

  • rename to ChangeLog.markdown
  • add release dates
  • add comparison links

Fixes #229

Copy link
Copy Markdown
Contributor

Thank you, this is a great improvement! A few comments:

  • Could you switch to RST? Everything else is RST, and it would allow us to add the changelog in the docs
  • Could you also amend you commit to fix the pep8 issue? Make the short commit message shorter, and add information in the commit message body.

Thanks!

Copy link
Copy Markdown
Contributor Author

Can you use variables for links in Rest like I used for the changes? See the bottom of the file. All this would need to be inline unless I overlooked something.

Copy link
Copy Markdown
Contributor

Yes, you can use something like:

Version 0.19_:
 * blah blah blah
.. _0.19: http://whatever.com

http://docutils.sourceforge.net/docs/user/rst/quickref.html#hyperlink-targets

Copy link
Copy Markdown
Contributor Author

Will try to do this today.

+ change indentation so bullet points are not treated as quote
+ add links to releases
+ add dates to releases
+ use releases as headers

Copy link
Copy Markdown
Contributor Author

It's done and the tests pass :)

Copy link
Copy Markdown
Contributor

Looks good, thank you!

gpocentek merged commit 37ee7ea into python-gitlab:master Mar 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL